-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor README #1836
base: main
Are you sure you want to change the base?
Refactor README #1836
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1836 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 17 17
Lines 1565 1565
Branches 338 338
=======================================
Hits 1547 1547
Misses 18 18 ☔ View full report in Codecov by Sentry. |
Remove more unnecessary information
Remove accidental added script
There are some strict guidelines regarding Meilisearch README that prevent me from reviewing this PR quickly. If you can make a separate PR for the playground updates, I could review it faster. Thanks! |
Okay I'll separate that. |
Hi @flevi29, thanks for your contribution. Meilisearch uses automated scripts to update the For now, I cannot allow the structure of this README to change, because it would affect our ability to batch update all repositories. Unfortunately, I can't prioritize working on this over the other tasks related to the v1.13 release. However, I opened an issue to track #1843 separately. I think that's the most important part of the PR for now, and I will review and merge ASAP. For the rest, we will have to revisit in the future. 🙏 |
Pull Request
What does this PR do?
README.md
, keep and refactor only what matterstypedoc
already does a way better job at documenting the API, which is linked in the "Documentation" sectionPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
todo: open issue about formatting everything that can be formatted with prettier