Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nodemon dependency #1822

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Jan 8, 2025

Pull Request

What does this PR do?

Previously nodemon was used for TypeScript watch mode, but TypeScript now supports watch mode by itself. For this reason we no longer require nodemon.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 added the maintenance Issue about maintenance (CI, tests, refacto...) label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (47a7997) to head (5baa0b8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1822   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          17       17           
  Lines        1565     1565           
  Branches      333      333           
=======================================
  Hits         1537     1537           
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Jan 8, 2025

@meili-bors meili-bors bot merged commit af27c78 into meilisearch:main Jan 8, 2025
7 checks passed
@flevi29 flevi29 deleted the remove-nodemon branch January 10, 2025 09:19
meili-bors bot added a commit that referenced this pull request Jan 14, 2025
1826: Update version for the next release (v0.48.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-js to a new version: "v0.48.0"

CHANGELOGS 👇

## ⚠️ Breaking changes

* Improve `token.ts` and make it tree-shakeable (#1661) `@flevi29`

**Migration**

Replace:
```ts
await generateTenantToken("74c9c733-3368-4738-bbe5-1d18a5fecb37", [], {
	apiKey: "0a6e572506c52ab0bd6195921575d23092b7f0c284ab4ac86d12346c33057f99",
	expiresAt: new Date("December 17, 4000 03:24:00"),
});
```

By:
```ts
await generateTenantToken({
	apiKey: "0a6e572506c52ab0bd6195921575d23092b7f0c284ab4ac86d12346c33057f99",
	apiKeyUid: "74c9c733-3368-4738-bbe5-1d18a5fecb37",
	searches: [],
	expiresAt: new Date("December 17, 4000 03:24:00"),
});
```

## ⚙️ Maintenance

* Switch from rollup to vite, from commonjs to ecmascript modules (#1740) `@\flevi29`
* Remove mention of support of Node 14 and 16 (#1805) `@\Strift`
* Fix and improve `eslint` config, other minor changes (#1795) `@\flevi29`
* Fix swapped args in localized-attributes sample (#1818) `@\ellnix`
* [Playground] Replace Parcel by Vite (#1821) `@\Strift`
* Switch from rollup to vite, from commonjs to ecmascript modules (#1740) `@\flevi29`
* Remove `nodemon` dependency (#1822) `@\flevi29`

Thanks again to `@\Strift,` `@\ellnix,` and `@\flevi29` 🎉


Co-authored-by: meili-bot <[email protected]>
meili-bors bot added a commit that referenced this pull request Jan 14, 2025
1826: Update version for the next release (v0.48.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-js to a new version: "v0.48.0"

CHANGELOGS 👇

## ⚠️ Breaking changes

* Improve `token.ts` and make it tree-shakeable (#1661) `@flevi29`

**Migration**

Replace:
```ts
await generateTenantToken("74c9c733-3368-4738-bbe5-1d18a5fecb37", [], {
	apiKey: "0a6e572506c52ab0bd6195921575d23092b7f0c284ab4ac86d12346c33057f99",
	expiresAt: new Date("December 17, 4000 03:24:00"),
});
```

By:
```ts
await generateTenantToken({
	apiKey: "0a6e572506c52ab0bd6195921575d23092b7f0c284ab4ac86d12346c33057f99",
	apiKeyUid: "74c9c733-3368-4738-bbe5-1d18a5fecb37",
	searches: [],
	expiresAt: new Date("December 17, 4000 03:24:00"),
});
```

## ⚙️ Maintenance

* Switch from rollup to vite, from commonjs to ecmascript modules (#1740) `@\flevi29`
* Remove mention of support of Node 14 and 16 (#1805) `@\Strift`
* Fix and improve `eslint` config, other minor changes (#1795) `@\flevi29`
* Fix swapped args in localized-attributes sample (#1818) `@\ellnix`
* [Playground] Replace Parcel by Vite (#1821) `@\Strift`
* Switch from rollup to vite, from commonjs to ecmascript modules (#1740) `@\flevi29`
* Remove `nodemon` dependency (#1822) `@\flevi29`

Thanks again to `@\Strift,` `@\ellnix,` and `@\flevi29` 🎉


Co-authored-by: meili-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants