Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention of support of Node 14 and 16 #1805

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Remove mention of support of Node 14 and 16 #1805

merged 2 commits into from
Dec 27, 2024

Conversation

Strift
Copy link
Collaborator

@Strift Strift commented Dec 19, 2024

Pull Request

Fixes #1804

@Strift Strift linked an issue Dec 19, 2024 that may be closed by this pull request
Update supported versions to Node 18 and 20 #1804
Closed
@Strift Strift marked this pull request as draft December 19, 2024 10:32
@Strift Strift force-pushed the chore/remove-node-14-16-support branch 2 times, most recently from dde2c96 to 4d0b695 Compare December 19, 2024 10:36
@Strift Strift changed the title Remove support for Node versions below 18 Remove mention of support of Node 14 and 16 Dec 19, 2024
@Strift Strift requested review from curquiza and flevi29 December 19, 2024 10:37
@Strift Strift marked this pull request as ready for review December 19, 2024 10:38
flevi29
flevi29 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flevi29 flevi29 self-requested a review December 19, 2024 10:57
flevi29
flevi29 requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no, can you also update CONTRIBUTING.md?

meilisearch-js/CONTRIBUTING.md

Lines 33 to 40 in 912465a

### Requirements
To run this project, you will need:
- Node.js >= v16 and node <= 18
- Yarn
- vitest

And vitest isn't a requirement, Yarn installs it.

@flevi29 flevi29 added the documentation Improvements or additions to documentation label Dec 19, 2024
@Strift Strift requested a review from flevi29 December 19, 2024 11:15
flevi29
flevi29 previously approved these changes Dec 19, 2024
View reviewed changes
curquiza
curquiza previously requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has nothing to do with v1.12 of Meilisearch and should point to main

@Strift Strift changed the base branch from bump-meilisearch-v0.12.0 to main December 22, 2024 09:11
@Strift Strift dismissed flevi29’s stale review December 22, 2024 09:11

The base branch was changed.

@Strift Strift marked this pull request as draft December 22, 2024 09:11
@Strift
Copy link
Collaborator Author

Strift commented Dec 22, 2024

Ok, thanks for the review. I will rebase the PR and look to merge it after the Meilisearch 1.12 release then

@Strift Strift self-assigned this Dec 22, 2024
@Strift Strift force-pushed the chore/remove-node-14-16-support branch from 41c5667 to 70c703f Compare December 27, 2024 08:20
@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (eb60101) to head (70c703f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1805   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files          18       18           
  Lines        1546     1546           
  Branches      326      326           
=======================================
  Hits         1514     1514           
  Misses         32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Strift Strift marked this pull request as ready for review December 27, 2024 08:24
@Strift Strift requested a review from curquiza December 27, 2024 08:24
@flevi29
Copy link
Collaborator

flevi29 commented Dec 27, 2024

bors merge

meili-bors bot added a commit that referenced this pull request Dec 27, 2024
@meili-bors @Strift
Merge #1805
7ad32e9 
1805: Remove mention of support of Node 14 and 16 r=flevi29 a=Strift

# Pull Request

Fixes #1804 


Co-authored-by: Strift <[email protected]>
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Dec 27, 2024

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

@Strift Strift dismissed curquiza’s stale review December 27, 2024 09:12

Changed base branch to main as requested

@Strift Strift merged commit d8ef010 into main Dec 27, 2024
6 of 7 checks passed
@Strift Strift deleted the chore/remove-node-14-16-support branch December 27, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flevi29 flevi29 flevi29 approved these changes

@curquiza curquiza Awaiting requested review from curquiza

Assignees

@Strift Strift

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update supported versions to Node 18 and 20
3 participants
@Strift @flevi29 @curquiza