Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported versions to Node 18 and 20 #1804

Closed
Strift opened this issue Dec 19, 2024 · 0 comments · Fixed by #1805
Closed

Update supported versions to Node 18 and 20 #1804

Strift opened this issue Dec 19, 2024 · 0 comments · Fixed by #1805
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Strift
Copy link
Collaborator

Strift commented Dec 19, 2024

Problem description

The README states that:

meilisearch-js officially supports node versions >= 14 and <= 18.

In practice, CI tests only include tests against Node 18 and Node 20.

I don't think we should support previous versions because neither is receiving security support anymore.

Proposal

Update the README accordingly.
@Strift Strift added documentation Improvements or additions to documentation good first issue Good for newcomers labels Dec 19, 2024
@Strift Strift mentioned this issue Dec 19, 2024
Merged
@Strift Strift linked a pull request Dec 19, 2024 that will close this issue
Remove mention of support of Node 14 and 16 #1805
Merged
@Strift Strift mentioned this issue Dec 19, 2024
Closed
meili-bors bot added a commit that referenced this issue Dec 27, 2024
@meili-bors @Strift
Merge #1805
7ad32e9 
1805: Remove mention of support of Node 14 and 16 r=flevi29 a=Strift

# Pull Request

Fixes #1804 


Co-authored-by: Strift <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove mention of support of Node 14 and 16 meilisearch/meilisearch-js
1 participant
@Strift