Introduce AnyTls
#315
Merged
Introduce AnyTls
#315
+387
−244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
previously requested changes
Mar 4, 2025
Kerollmops
force-pushed
the
any-tls
branch
4 times, most recently
from
a8e1659 to
db41d3f
Compare
Kerollmops
force-pushed
the
any-tls
branch
2 times, most recently
from
1ee34ba to
100b429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #314
What does this PR do?
AnyTlsRoTxn<T>decay toRoTxn<AnyTls>EnvandRoTxnto separate the phantomT(WithTls/WithoutTls/AnyTls) and the data + makes them repr transparent.Tfrom cursors: these types can never beSendbecause they morally have a reference to aRoTxn, which is notSync.Sendimplementations of all the iterators.