UI polish pr3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RainingComputers
force-pushed
the
ui-polish-pr3
branch
from
5d2f832 to
12af028
Compare
| @@ -8,7 +8,7 @@ | |||
| class=" bg-gray-50 border-gray-200 border-r flex flex-col gap-1 py-5" | |||
| style="width: {width}" | |||
| data-cy="explorer" | |||
| transition:fly={{ x: -400, duration: 350, opacity: 1 }} | |||
| transition:fly|local={{ x: -400, duration: 120, opacity: 1 }} | |||
There was a problem hiding this comment.
Because when we logout (transition to another page), we will have to wait for the panel to close, which impacts UX local will prevent that.
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| <nav | |||
| class="flex flex-row w-full h-12 drop-shadow-card bg-slate-800 items-center px-4 py-7 gap-2" | |||
| transition:fly={{ y: -50, duration: 350, opacity: 1 }} | |||
| in:fly={{ y: -50, duration: 100, opacity: 1 }} | |||
There was a problem hiding this comment.
Why does it matter? When do we have an out for the toolbar?
There was a problem hiding this comment.
We have an out when we transition to another page (logout), so the user has to wait for the toolbar to out before it goes to the login page, which impacts UX, so changed it to only have in
There was a problem hiding this comment.
Oh nice - great catch
|
This one is all yours man. LGTM :) |
RainingComputers
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.