Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ziw-liu @mattersoflight I can demo my progress tomorrow to help us put together a plan.
I've tested this branch against
waveorder
'spol-refactor
branch.Confirmed working:
calculate-transfer-function
andapply-inverse-transfer-function
can perform all reconstruction stepsMajor limitations to address:
recOrder
side based on my tests, but I'll look closer tomorrowMinor limitations:
reconstruct
method yet...this will be a fairly easy last steprecOrder
...commented for now to smooth the transitionapply_inverse_transfer_function
is where most of the densestrecOrder
-waveorder
logic lives (these recOrder settings require these TFs applied in this way to thesewaveorder
models). I could likely use some improvement to my use ofiohub
.