Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compatibility with 13.40 #840

Merged
merged 14 commits into from
Aug 13, 2024
Merged

feat: compatibility with 13.40 #840

merged 14 commits into from
Aug 13, 2024

Conversation

kokekanon
Copy link
Collaborator

@kokekanon kokekanon commented Aug 9, 2024

Description

https://github.com/opentibiabr/canary/pull/2802/files

pr of canary contains the following modifications

Changes pr canary Send/get Done
Cyclopedia get
Wheel get
Quick Loot get
onRecvFirstMessage send
parseSetOutfit send
sendContainer get
trade npc get
new assent

can Login
can Trade Npc

test in 8.6 ,13,32,13.40
in 1100 I think there is a bug but it is from canary

I believe that it is necessary to modify the xd src\protobuf\appearances.pb.cc
I thought it would be easier xd

Type of change

  • New feature (non-breaking change which adds functionality)

Test Configuration:

  • Server Version: 1340 1332 860
  • Client: pr 840
  • Operating System: windows 10+1

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@kokekanon kokekanon marked this pull request as draft August 9, 2024 04:57
src/client/protocolgameparse.cpp Outdated Show resolved Hide resolved
modules/gamelib/game.lua Outdated Show resolved Hide resolved
src/client/protocolgameparse.cpp Outdated Show resolved Hide resolved
@Nottinghster Nottinghster marked this pull request as ready for review August 12, 2024 17:47
@luanluciano93 luanluciano93 merged commit c69f5bd into mehah:main Aug 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants