Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forge skills #779

Merged
merged 1 commit into from
Jun 1, 2024
Merged

fix: forge skills #779

merged 1 commit into from
Jun 1, 2024

Conversation

luanluciano93
Copy link
Collaborator

@luanluciano93 luanluciano93 commented May 28, 2024

  • fix error:

ERROR: Lua exception: /game_skills/skills.lua:104: attempt to index local 'skill' (a nil value)
stack traceback:
    [C]: in function '__index'
    /game_skills/skills.lua:104: in function 'setSkillBase'
    /game_skills/skills.lua:512: in function </game_skills/skills.lua:511>
ERROR: protected lua call failed: LUA ERROR:
/game_skills/skills.lua:104: attempt to index local 'skill' (a nil value)
stack traceback:
    [C]: in function '__index'
    /game_skills/skills.lua:104: in function 'setSkillBase'
    /game_skills/skills.lua:512: in function </game_skills/skills.lua:511>
  • removed redundancy in onBaseSkillChange's refresh() function
    image
    image

  • readjustment for forge skills only appear when they are greater than 0

transcendencia.mp4

@mehah mehah merged commit cc479a3 into mehah:main Jun 1, 2024
10 checks passed
@luanluciano93 luanluciano93 deleted the fix-skills branch June 1, 2024 21:47
@kojimhojo
Copy link

image

this is displayed on older servers (8.6) , there should be an if of x version @luanluciano93

@luanluciano93
Copy link
Collaborator Author

this is displayed on older servers (8.6) , there should be an if of x version @luanluciano93

test plx https://github.com/mehah/otclient/pull/784/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants