fix: incorrect usage of const ref shared ptr in container class #1010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an invalid (unsafe) usage of const reference to shared_ptr in container class.
Behavior
Actual
Crashes with stacktrace pointing to LuaInterface::pushObject. This happens, because the const ref is unsafe there.
After you remove the shared pointer from container it may get destructured (shared_ptr is a normal instance of a class).
This happens in this case, we need a copy to keep the pointer alive here.
I haven't had luck with reproducing this in Release mode, likely, because compiler somehow optimizes the code.
Stacktrace:
Expected
I reproduced this crash several times by running around and spamming ultimate healing runes with open backpacks via action bar.
Fixes
not a reported issue
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist