Fix incorrect usage of const ref shared ptr in container class

mehah · Jan 1, 2025 · c6278fa · c6278fa
1 parent b9f7dfa
commit c6278fa
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/client/container.cpp b/src/client/container.cpp
@@ -85,7 +85,7 @@ void Container::onUpdateItem(int slot, const ItemPtr& item)
         return;
     }
 
-    const auto& oldItem = m_items[slot];
+    const auto oldItem = m_items[slot];
     m_items[slot] = item;
     item->setPosition(getSlotPosition(slot));
 
@@ -106,7 +106,7 @@ void Container::onRemoveItem(int slot, const ItemPtr& lastItem)
         return;
     }
 
-    const auto& item = m_items[slot];
+    const auto item = m_items[slot];
     m_items.erase(m_items.begin() + slot);
 
     if (lastItem) {
@@ -126,4 +126,4 @@ void Container::updateItemsPositions()
 {
     for (int slot = 0; slot < static_cast<int>(m_items.size()); ++slot)
         m_items[slot]->setPosition(getSlotPosition(slot));
-}
+}