-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch to smaller dependencies to reduce bundle size #525
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,8 @@ | |
"prettier": "npx prettier --write ." | ||
}, | ||
"dependencies": { | ||
"lodash-es": "^4.17.21", | ||
"fast-deep-equal": "^3.1.3", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion (llm): Please ensure that the integration tests also reflect the change in dependencies. It's important to verify that the integration points where There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion (llm): It's commendable that the bundle size has been significantly reduced by switching dependencies. However, it's equally important to ensure that performance benchmarks, if any, are updated or added to reflect the impact of these changes. Performance tests can help in understanding if the new dependencies introduce any latency or execution bottlenecks compared to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion (llm): The switch to |
||
"klona": "^2.0.6", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion (llm): Considering the replacement of |
||
"lottie-web": "5.12.2" | ||
}, | ||
"peerDependencies": { | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (llm): Given the switch from
lodash-es
tofast-deep-equal
andklona
, it's crucial to ensure that the existing unit tests cover scenarios where deep equality checks and deep cloning are performed. If such tests are not present, I recommend adding them to verify that the new dependencies behave as expected in all use cases previously covered bylodash-es
.