Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support go1.21 build #471

Closed
wants to merge 3 commits into from
Closed

Conversation

chenrui333
Copy link

Right now, there is some go.sum discrepancies with go1.21 build, run go mod tidy with go1.21.6 to support go1.21 build.

@chenrui333
Copy link
Author

this is very similar to kubecm pr, sunny0826/kubecm#847

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b20cabd) 98.78% compared to head (1efcf1f) 98.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   98.78%   98.88%   +0.09%     
==========================================
  Files          85       83       -2     
  Lines        5863     5844      -19     
==========================================
- Hits         5792     5779      -13     
+ Misses         52       48       -4     
+ Partials       19       17       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samanhappy
Copy link
Collaborator

@chenrui333 there is a failed test here with the following logs:

=== RUN   TestMemcache
    memcache_test.go:48: 
        	Error Trace:	D:/a/easeprobe/easeprobe/probe/client/memcache/memcache_test.go:48
        	Error:      	"dial tcp 127.0.0.1:12345: connectex: No connection could be made because the target machine actively refused it." does not contain "connect timeout"
        	Test:       	TestMemcache
--- FAIL: TestMemcache (0.02s)

please help to check if it's caused by these changes or if the test code needs optimization to align?

@chenrui333
Copy link
Author

@samanhappy I guess we can do a quick rerun to see if it is reproducible, looks like only failed with windows build.

@samanhappy
Copy link
Collaborator

samanhappy commented Jan 17, 2024

@chenrui333 it's reproducible and seems to be caused by some low-level implementation in go 1.21 on Windows, you can try to fix it like what I did here.

@chenrui333
Copy link
Author

yeah, let me give a try later, thanks!

@suchen-sci
Copy link
Contributor

Hi, @chenrui333 could you please fix it? We'd like to update easeprobe to golang 1.21.

@suchen-sci
Copy link
Contributor

we are now in go 1.21, so i will close this pr.

@suchen-sci suchen-sci closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants