-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support go1.21 build #471
Conversation
this is very similar to kubecm pr, sunny0826/kubecm#847 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 98.78% 98.88% +0.09%
==========================================
Files 85 83 -2
Lines 5863 5844 -19
==========================================
- Hits 5792 5779 -13
+ Misses 52 48 -4
+ Partials 19 17 -2 ☔ View full report in Codecov by Sentry. |
@chenrui333 there is a failed test here with the following logs:
please help to check if it's caused by these changes or if the test code needs optimization to align? |
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
@samanhappy I guess we can do a quick rerun to see if it is reproducible, looks like only failed with windows build. |
@chenrui333 it's reproducible and seems to be caused by some low-level implementation in go 1.21 on Windows, you can try to fix it like what I did here. |
yeah, let me give a try later, thanks! |
Hi, @chenrui333 could you please fix it? We'd like to update easeprobe to golang 1.21. |
we are now in go 1.21, so i will close this pr. |
Right now, there is some go.sum discrepancies with go1.21 build, run
go mod tidy
with go1.21.6 to support go1.21 build.