Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version bug #310

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Fix the version bug #310

merged 1 commit into from
Mar 14, 2023

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Mar 13, 2023

since #307 introduced the tag for Helm Chart, the PR impacts the easeprobe's build version, because the Makefile always retrieved the latest tag.

Before this fix:

> easeprobe -v
EaseProbe easeprobe-helm-charts-v1.0.0 8b36e4424 2023-03-11T01:02:40Z go1.19.4

After this fix

> easeprobe -v                                                                                                                                                                   ─╯
EaseProbe v2.0.1 8b36e4424 2023-03-11T01:02:40Z go1.19.4

@haoel haoel requested a review from samanhappy March 13, 2023 14:22
@haoel haoel added this pull request to the merge queue Mar 14, 2023
Merged via the queue into megaease:main with commit 56adf27 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants