Make janus.js pass linter

[davel]

Hello,

I have attempted to get janus.js to pass a JavaScript linter. The changes mostly relate to variable scope one way or the other, I hope they are improvements. I have also enabled "use strict"; as the code appears to be safe with regards to that. Testing with our application does not find any problems with these changes.

I have also configured GitHub actions to automatically run eslint along with the rest of the CI process.

[lminiero]

I have no idea what linter is, so I'll leave considerations to younger folks like @atoppi 🙂

[atoppi]

Hi @davel thanks for the effort.
I've left some notes, my only concern is about the rule set you are using in eslint.
What is the source / rationale of that ? It is way too large to check if any rule is really needed.

[lminiero]

Added a few (clueless) comments.

[atoppi]

All right, LGTM 👍

[lminiero]

I'm not knowledgeable enough on the matter to have an opinion, so I'll trust @atoppi's review and notes. I do know that I'll start insulting you all if this translates to a ton of conflicts to resolve on the multistream branch, though 🤣

[atoppi]

merging...