Allow specifying multiple IP addresses for 1-1 NAT.

[fancycode]

This can be used if Janus is deployed in a DMZ between two 1-1 NAT firewalls for external and internal users.

I am using something like this for the scenario described in https://groups.google.com/d/msg/meetecho-janus/x-LhB_cTs7k/fHT4i5pzBQAJ

[lminiero]

Thanks! This does seem useful, but I'll have to do a deeper review, since there's a lot of new code. I'm a bit busy these days, so that may take a while. Please ping me if I haven't come back to you in a few days.

[lminiero]

Did a first review, and added a few notes. I think the way the IPs are added/kept should be changed, you can find more details in the comments.

[fancycode]

Thanks for your feedback, all comments addressed. Public IPs are now stored in a GHashTable to handle duplicates and are extracted with g_hash_table_get_keys (which is cached).

[fancycode]

Should I rebase now or do you want to finish your review first?

[lminiero]

I won't be able to do another review today, sorry... I'll check again tomorrow.

[fancycode]

No worries, take your time. I can rebase whenever you are ready with the review.

[lminiero]

I added a small note. The code looks fine to me (I'll test after it's rebased, before I merge), I'm just a bit concerned by the fact we now have a bunch of do..while that would in the vast majority of cases (no nat-1-1) not be needed. I guess there won't be much of a performance impact though.

[lminiero]

Thanks! I'll make a couple of tests after lunch and merge if I don't spot anything strange 👍

[lminiero]

Just made a few tests and it seems to be working as expected, merging!