[1.x] Janus SIP Custom headers length

[l-alexandrov]

What version of Janus is this happening on?
v1.1.2

Have you tested a more recent version of Janus too?
No. The problem is on the master branch too.

Was this working before?
I don't know.

Is there a gdb or libasan trace of the issue?
No.

Additional context
The custom headers' values are truncated to 255 characters. We need to transmit JSON Web Token Authentication headers which are much longer than 255 characters.
https://github.com/meetecho/janus-gateway/blob/master/src/plugins/janus_sip.c#L1624-L1650

[lminiero]

I think that 255 is hardcoded in a couple of other places as well. It should be an easy fix, though. I'll have a look later today and push a fix in case.

[lminiero]

I increased the size from 255 to 1024, I hope that's enough (how large can those tokens be 😛 )
As a side note, 1.1.2 is almost two years old: you should seriously consider upgrading, since there have been a ton of fixes to both the core and the SIP plugin in the meanwhile (you can refer to the changelog for details).

[l-alexandrov]

Thanks for the quick reaction. The increasing of the limit will reveal very great potential to developers using Janus!

Specifically for authentication though, when using JWTs, we usually use at least 2048-bit keys for signing them. (Reference)

For example, Laravel (Passport) by default generates 4096 bit keys.
That makes the tokens' length vary between 1200-2000 characters for an average JWT payload.

I see that this may look extremely long, but it's kind of standard. In these days a bare minimum according to me.
What's more, most of the HTTP servers have ~2Kb limit for a single HTTP header.

So, may we increase the length to at least 2048 characters?

[lminiero]

Ack, just done.