Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency csharpier to v0.26.5 #50

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 23, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
csharpier 0.26.2 -> 0.26.5 age adoption passing confidence

Release Notes

belav/csharpier (csharpier)

v0.26.5

Compare Source

v0.26.4

Compare Source

What's Changed

Spacing bugs related to C#12 collection expressions #​1049 #​1047

There were a number of cases where CSharpier was including extra blank lines, an extra space, or not formatting contents of collection expressions.

// 0.26.3
var a = new A { B =  [1, 2, 3] };

List<string> items = [// My item
    "Hello",];

items.AddRange(

    [
        LongValue________________________________________________,
        LongValue________________________________________________
    ]
);

items =  [];
items ??=  [];

class SomeClass
{
    public SomeValue SomeProperty =>

        [
            LongValue________________________________________________,
            LongValue________________________________________________
        ];

    public SomeValue Method() =>

        [
            LongValue________________________________________________,
            LongValue________________________________________________
        ];
}

// 0.26.4
var a = new A { B = [1, 2, 3] };

List<string> items =
[
    // My item
    "Hello",
];

items.AddRange(
    [
        LongValue________________________________________________,
        LongValue________________________________________________
    ]
);

items = [];
items ??= [];

class SomeClass
{
    public SomeValue SomeProperty =>
        [
            LongValue________________________________________________,
            LongValue________________________________________________
        ];

    public SomeValue Method() =>
        [
            LongValue________________________________________________,
            LongValue________________________________________________
        ];
}

Thanks go to @​fgimian and @​JoshWoodArup for reporting the issues

Usings sorting differs based on system culture #​1051

The sorting of Usings was done in a culture specific manner, resulting in unexpected behavior.
In Czech (cs-CZ) the ch is a "single letter" which is placed between h and i, which resulted in the following sorting behavior.

// 0.26.3
using Microsoft.ApplicationInsights.DataContracts;
using Microsoft.ApplicationInsights.Extensibility;
using Microsoft.ApplicationInsights.Channel;

// 0.26.4
using Microsoft.ApplicationInsights.Channel;
using Microsoft.ApplicationInsights.DataContracts;
using Microsoft.ApplicationInsights.Extensibility;

Thanks go to @​davidkudera for the contribution

Full Changelog: belav/csharpier@0.26.3...0.26.4

v0.26.3

Compare Source

What's Changed

C#12 Collection expressions are prefixed with two spaces #​1009
// 0.26.0
List<int> ids =  [];

// 0.26.3
List<int> ids = [];

Thanks go to @​Jackenmen for reporting the problem.

CSharpier inserts extra spaces around the contents of collection expressions #​1002
// 0.26.0
List<int> ids = [ ];
List<int> ids = [ 1, 2, 3 ];

// 0.26.3
List<int> ids = [];
List<int> ids = [1, 2, 3];

Thanks go to @​golavr for reporting the problem.

Configuration files not respected for stdin #​1028

When piping a file to csharpier via stdin, CSharpier uses the working directory to locate any configuration files. This was broken with 0.26.0.

Thanks go to @​kikniknik for reporting the problem.

Modify CSharpier.MSBuild to use NETCoreSdkVersion to detect which sdk to use for running CSharpier #​1022 #​1027

Previously CSharpier.MSBuild was using targetFramework to determine which version of CSharpier to run. This was problematic when there were multiple target frameworks, or the project was targeting a superset such as net8.0-windows

It now makes use of NETCoreSdkVersion to determine which version of CSharpier to run.

Thanks go to @​Tyrrrz for the suggestion and to @​Cjewett for the contribution to make it work

CSharpierIgnore not respected when recursively finding .editorconfig

When looking for .editorconfig files, CSharpier looks for them recursively in the current directory. This logic was not taking into account any files or directories ignored by a .csharpierignore.

Thanks go to @​sebastieng84 for the contribution.

Optimize editorconfig lookups when piping files #​1039

CSharpier now only looks for an .editorconfig for the file being piped to CSharpier. Under normal usage it recursively looks for all possible .editorconfig files for the given directory.

Full Changelog: belav/csharpier@0.26.2...0.26.3


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21580fd) 61.78% compared to head (679fe66) 61.78%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   61.78%   61.78%           
=======================================
  Files          31       31           
  Lines         539      539           
  Branches       39       39           
=======================================
  Hits          333      333           
  Misses        203      203           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title chore(deps): update dependency csharpier to v0.26.3 chore(deps): update dependency csharpier to v0.26.4 Dec 2, 2023
@renovate renovate bot force-pushed the renovate/csharpier-0.x branch from f69eb4f to 1010746 Compare December 2, 2023 18:53
Copy link

sonarqubecloud bot commented Dec 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@renovate renovate bot changed the title chore(deps): update dependency csharpier to v0.26.4 chore(deps): update dependency csharpier to v0.26.5 Dec 10, 2023
@renovate renovate bot force-pushed the renovate/csharpier-0.x branch from 1010746 to 679fe66 Compare December 10, 2023 18:15
@meenzen meenzen merged commit d823948 into main Dec 10, 2023
4 checks passed
@renovate renovate bot deleted the renovate/csharpier-0.x branch December 10, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant