-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hanging GETINFO #390
hanging GETINFO #390
Conversation
@hellais if it's easy to test, would appreciate your feedback as to whether this fixes your issue? |
I have tested this PR and am happy to confirm it fixes the issue reported in #389. I will run this branch against the full exit list and once it's done report back if it's causing any issues due to maximum length being reached. Question ❓ : What will happen if there is a descriptor line which is longer than 2^20? Will it produce an error that hints at the fact this is the reason for the failure? |
No, it'll nuke the connection like it does now :( Another solution would be to have "no limit". Twisted's implementation doesn't allow for this directly, but either re-writing or "more overriding" should be able to remove it (or set the limit to MAX_INT). There'd still be a limit of course (available memory). |
Fixes #389