Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hanging GETINFO #390

Merged
merged 8 commits into from
Aug 30, 2023
Merged

hanging GETINFO #390

merged 8 commits into from
Aug 30, 2023

Conversation

meejah
Copy link
Owner

@meejah meejah commented Aug 29, 2023

Fixes #389

@coveralls
Copy link

coveralls commented Aug 29, 2023

Coverage Status

coverage: 99.574%. remained the same when pulling caf0b38 on 389.hang-getinfo into c0c98ff on main.

@meejah
Copy link
Owner Author

meejah commented Aug 29, 2023

@hellais if it's easy to test, would appreciate your feedback as to whether this fixes your issue?

@hellais
Copy link
Contributor

hellais commented Aug 30, 2023

I have tested this PR and am happy to confirm it fixes the issue reported in #389.

I will run this branch against the full exit list and once it's done report back if it's causing any issues due to maximum length being reached.

Question ❓ : What will happen if there is a descriptor line which is longer than 2^20? Will it produce an error that hints at the fact this is the reason for the failure?

@meejah
Copy link
Owner Author

meejah commented Aug 30, 2023

Question ❓ : What will happen if there is a descriptor line which is longer than 2^20? Will it produce an error that hints at the fact this is the reason for the failure?

No, it'll nuke the connection like it does now :(
Not ideal, obviously --- I've filed #391 to remind future humans to produce a better message.

Another solution would be to have "no limit". Twisted's implementation doesn't allow for this directly, but either re-writing or "more overriding" should be able to remove it (or set the limit to MAX_INT). There'd still be a limit of course (available memory).

@meejah meejah merged commit 668d829 into main Aug 30, 2023
15 checks passed
@meejah meejah deleted the 389.hang-getinfo branch August 30, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When tor process exits unexpectedly tor.protocol.get_info hangs
3 participants