Fix TypeError: Cannot destructure property 'name' of '{}' as it is null. #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielevalverde
requested review from
amoedoamorim and
sarahkeh
as code owners
amoedoamorim
approved these changes
Feb 7, 2025
Comment on lines
-121
to
+122
| media_cluster_origin_user: { name: user } = {}, | ||
| }, | ||
| media_cluster_origin_user: user = {}, | ||
| } = {}, |
There was a problem hiding this comment.
[comment] (non-blocker) I'm not a fan of this nested destructuring, but it works. Just a personal preference, I guess... 🤷
Comment on lines
112
to
116
| media_cluster_origin_user: { name: user } = {}, | ||
| media_cluster_origin_user: user = {}, | ||
| media_cluster_relationship: mediaClusterRelationship, | ||
| }, | ||
| }) => { | ||
| const { icon, message } = getIconAndMessage(origin, mediaClusterRelationship, user, originTimestamp); | ||
| const { icon, message } = getIconAndMessage(origin, mediaClusterRelationship, user?.name, originTimestamp); |
There was a problem hiding this comment.
[comment] (non-blocker) If user is being assigned an empty object by default then the safe navigation operator shouldn't be necessary, right?
There was a problem hiding this comment.
removed the unnecessary safe operator, @amoedoamorim 🫡
danielevalverde
added a commit
that referenced
this pull request
Feb 7, 2025
…ll. (#2285) * Fix TypeError: Cannot destructure property 'name' of '{}' as it is null. * remove unecessary safe operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid trying to destructure the prop of null
References: 5510
How to test?
Running unit tests and manually
Checklist