Fixing a couple of regressions (missing GraphQL fields). #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both regressions affect the media card on the item page: * Request the `relationship.target.created_at` field, so we can fallback to it when `last_seen` is `null`. * Request the `relationship.target.requests_count` field, which is currently causing a "NaN Requests" error. Fixes: CV2-6126.
caiosba
requested review from
amoedoamorim,
danielevalverde and
sarahkeh
as code owners
caiosba
requested review from
brianfleming,
amoedoamorim,
danielevalverde and
sarahkeh
and removed request for
amoedoamorim,
danielevalverde and
sarahkeh
|
Reviewers, I merged because it was an urgent fix for live... but please review! |
|
Thanks Sarah! I'm going to deploy to live now. |
caiosba
added a commit
that referenced
this pull request
Feb 6, 2025
Both regressions affect the media card on the item page: * Request the `relationship.target.created_at` field, so we can fallback to it when `last_seen` is `null`. * Request the `relationship.target.requests_count` field, which is currently causing a "NaN Requests" error. Fixes: CV2-6126.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both regressions affect the media card on the item page:
relationship.target.created_atfield, so we can fallback to it whenlast_seenisnull.relationship.target.requests_countfield, which is currently causing a "NaN Requests" error.Fixes: CV2-6126.
How to test?
Open any media cluster page that has more than one media.
Previously:
Now:
Checklist