-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing adjustments #2231
Spacing adjustments #2231
Conversation
… some tabs feedback, adjust minor wording in toast message
@@ -19,7 +19,7 @@ | |||
} | |||
|
|||
.listMainAction { | |||
padding: 0 18px; | |||
padding: 0 16px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed atypical use of 18 vs 16px
cc @caiosba this was the PR i mentioned during our 1:1 |
Thanks, @brianfleming - @sarahkeh , can you please take the first review and ask for @amoedoamorim to do a second review if needed? We want to get these fixes in at the same time as the other fixes I'm going to deploy for the data dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* adjustments to some spacing to make more room for UI as a response to some tabs feedback, adjust minor wording in toast message * simplify some sizing and use the youtube min max list size for large media card
Description
Some layout changes to make more room for UI elements. There has been some feedback after the last tabs changes, this further refines layout to make things more consistent:
Unrelated:
Type of change
How has this been tested?
visited all major page layouts in app to verify consistent margin/padding
Things to pay attention to during code review
Checklist
propTypes
are declared and they use React Hooks and, if data-fetching is required, they use Relay Modern with fragment containers