Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/cv2-5791 tab wrapper wraps based on wrapContent prop #2226

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

sarahkeh
Copy link
Contributor

@sarahkeh sarahkeh commented Dec 9, 2024

Description

Tab Wrapper takes in a new prop, wrapContent (default false), that allows the container to wrap up to 2 rows before breaking to a Select dropdown component. Removed the height value for large as it was cutting off the wrapped row.

References: CV2-5791

Type of change

  • Performance improvement and/or refactoring (non-breaking change that keeps existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Security mitigation or enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Automated test (add or update automated tests)

How has this been tested?

Manually

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I've made sure my branch is runnable and given good testing steps in the PR description
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I implemented any new components, they are self-contained, their propTypes are declared and they use React Hooks and, if data-fetching is required, they use Relay Modern with fragment containers
  • If my components involve user interaction - specifically button, text fields, or other inputs - I have added a BEM-like class name to the element that is interacted with
  • To the best of my knowledge, any new styles are applied according to the design system
  • If I added a new external dependency, I included a rationale for doing so and an estimate of the change in bundle size (e.g., checked in https://bundlephobia.com/)
  • If I touched a file that included an eslint-disable-file header, I updated the code such that the disabler can be removed

Copy link
Contributor

@brianfleming brianfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good from my end @sarahkeh
lets get @amoedoamorim and/or @danielevalverde to take a look for real review

@brianfleming
Copy link
Contributor

cc @caiosba for visibility and possibly deployment when merged

@sarahkeh sarahkeh merged commit fe3fda2 into develop Dec 9, 2024
11 checks passed
@sarahkeh sarahkeh deleted the fix/cv2-5791-tab-wrapper-wraps branch December 9, 2024 21:13
caiosba pushed a commit that referenced this pull request Dec 9, 2024
* added wrapping that is conditional based on wrapContent prop, break if larger than 2 rows

* use tabs on sandbox for testings, remove stray comment in variables file, tweak some tabs spacing

* remove testing console log

---------

Co-authored-by: Brian Fleming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants