Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z-index fixes #2225

Merged
merged 1 commit into from
Dec 8, 2024
Merged

z-index fixes #2225

merged 1 commit into from
Dec 8, 2024

Conversation

brianfleming
Copy link
Contributor

Description

  • add new css variables for z-indexing
  • update style linting rules to enforce using z-index variables
  • update code to use new vars and fix stacking order for media cards and slideouts

References: CV2-5792

Type of change

  • Performance improvement and/or refactoring (non-breaking change that keeps existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Security mitigation or enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Automated test (add or update automated tests)

How has this been tested?

manual verification on media types

Things to pay attention to during code review

no much, just css changes to verify

Checklist

  • I have performed a self-review of my own code
  • I've made sure my branch is runnable and given good testing steps in the PR description
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I implemented any new components, they are self-contained, their propTypes are declared and they use React Hooks and, if data-fetching is required, they use Relay Modern with fragment containers
  • If my components involve user interaction - specifically button, text fields, or other inputs - I have added a BEM-like class name to the element that is interacted with
  • To the best of my knowledge, any new styles are applied according to the design system
  • If I added a new external dependency, I included a rationale for doing so and an estimate of the change in bundle size (e.g., checked in https://bundlephobia.com/)
  • If I touched a file that included an eslint-disable-file header, I updated the code such that the disabler can be removed

@brianfleming brianfleming marked this pull request as ready for review December 8, 2024 17:19
@brianfleming brianfleming requested a review from caiosba December 8, 2024 17:19
@brianfleming
Copy link
Contributor Author

FYI to front-end developers, not the change to styelinting rules to enforce using variables for z-indexs

@caiosba caiosba merged commit 8a58cbe into develop Dec 8, 2024
11 checks passed
caiosba pushed a commit that referenced this pull request Dec 8, 2024
@brianfleming brianfleming deleted the brianfleming/dev/z-index-var branch December 9, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants