You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the code is a 1:1 match with the last version of datetime-attribute in terms of feature.
List of things:
Use the Temporal API everywhere it’s possible to be familiar with its ergonomics.
Update the test cases to be on par with recent updates on main.
How to enhance the API of datetime-attribute with Temporal specifics? For example: on top of accepting Date objects, most functions could also accept some of the many Temporal objects.
Currently, this PR makes use of the Temporal API everywhere it can so that I can experiment a bit with its big set of features. But it should be changed to only make use of it everywhere it should, and keep the regular Date API. This should be done after having experimented/played with additional features (see previous point).
Generate types (only done for the non-Temporal implementation for now)
Think about new test cases coming with the specificities of Temporal API
Document
How to release this experimental version?
Should @js-temporal/polyfill stays as peerDependencies? If yes, it allows size-limit to report the “real” size because the polyfill will not end in the final bundle. If no, it should be moved to devDependencies so it doesn’t required to be installed for the regular datetime-attribute, which doesn’t need the polyfill. Complicated.
Addition of Duration Attribute
The addition of the src/temporal/duration.js file brings the ability to create a duration attribute for time tags, allowing more precise control over timing features.
Export of Duration Function
The new src/temporal/index.js file allows the previously implemented duration function to be exported for wider accessibility and use within the codebase.
Introduction of Date Calculations Functions
Further enhancing our temporal control, the src/temporal/utils/date.js file contains functions for calculating differences between two given dates in days and determining the week number of a specific date.
Conversion of Date Object Function
A new utility function dateToPlainDate is introduced in src/temporal/utils/temporal.js file to make the conversion of a JavaScript Date object to a Temporal.PlainDate object smoother.
Path Addition in package.json
The package.json file has been updated with a new path src/temporal/index.js utilizing brotli compression for optimized use.
New Dependency Addition
For further enhancement and functionality, @js-temporal/polyfill dependency has been added with a version of ^0.4.4 in the pnpm-lock.yaml file.
Resolutions and Dependencies update
The pnpm-lock.yaml file has also been updated with new resolutions and dependencies for [email protected] and [email protected], ensuring all elements are up-to-date and secure.
Please note that these changes improve efficiency, calculation capacity and speed up some processes, hence enhance the user's experience.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meduzen
force-pushed
the
experiment-temporal-api
branch
from
Currently the code is a 1:1 match with the last version of
datetime-attributein terms of feature.List of things:
main.datetime-attributewith Temporal specifics? For example: on top of acceptingDateobjects, most functions could also accept some of the many Temporal objects.Temporalimplementation for now)TemporalAPI@js-temporal/polyfillstays aspeerDependencies? If yes, it allowssize-limitto report the “real” size because the polyfill will not end in the final bundle. If no, it should be moved todevDependenciesso it doesn’t required to be installed for the regulardatetime-attribute, which doesn’t need the polyfill. Complicated.