fix: Do not print "not coherent" logs on first external linking

medikoo · Sep 8, 2024 · 47c7871 · 47c7871
1 parent 122c3b1
commit 47c7871
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/setup-dependency/install-external/index.js b/lib/setup-dependency/install-external/index.js
@@ -58,17 +58,19 @@ module.exports = async (dependencyContext, userConfiguration, progressData) => {
 	}
 	if (isToBeLinked) {
 		const linkedPath = relative(dirname(path), sourceDirname);
-		if (!(await isSymlink(path, { linkPath: linkedPath }))) {
+		if (await isSymlink(path, { linkPath: linkedPath })) {
+			if (await isCoherent(dependencyContext, getPackageJson(path))) return;
+			log.notice("%s not coherent %s, relinking binaries", dependentContext.name, name);
+		} else {
 			const isInstalled = await lstat(path, { loose: true });
 			if (isInstalled) await rm(path, { loose: true, recursive: true, force: true });
 			log.notice("%s linking %s @ %s", dependentContext.name, name, targetVersion);
 			await symlink(linkedPath, path, { intermediate: true });
 			dependentContext.installationJobs.add(
 				`${ isInstalled ? "update" : "install" }-dependency:${ name }`
 			);
+			if (await isCoherent(dependencyContext, getPackageJson(path))) return;
 		}
-		if (await isCoherent(dependencyContext, getPackageJson(path))) return;
-		log.notice("%s not coherent %s, relinking binaries", dependentContext.name, name);
 	} else {
 		const isInstalled = await isDirectory(path);
 		const dependencyPackageJson = isInstalled ? getPackageJson(path) : null;