refactor: Exclude isSemVerRange utility

medikoo · Feb 28, 2024 · 0e869a6 · 0e869a6
1 parent 259386a
commit 0e869a6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/lib/setup-dependency/index.js b/lib/setup-dependency/index.js
@@ -2,11 +2,11 @@
 
 const { resolve }       = require("path")
     , log               = require("log").get("npm-cross-link")
-    , semver            = require("semver")
     , getNpmModulesPath = require("../get-npm-modules-path")
     , setupExternal     = require("./setup-external")
     , setupLocal        = require("./setup-local")
-    , resolveLogLevel   = require("./resolve-log-level");
+    , resolveLogLevel   = require("./resolve-log-level")
+    , isSemVerRange     = require("../utils/is-sem-ver-range");
 
 const getVersionRange = ({ dependentContext, name }) => {
 	if (
@@ -30,11 +30,6 @@ const getVersionRange = ({ dependentContext, name }) => {
 	return null;
 };
 
-const isSemVerValidRange = versionRange => {
-	if (versionRange === "latest") return true;
-	return semver.validRange(versionRange);
-};
-
 module.exports = async (dependencyContext, userConfiguration, inputOptions, progressData) => {
 	const { dependentContext, name, isExternal } = dependencyContext;
 
@@ -46,7 +41,7 @@ module.exports = async (dependencyContext, userConfiguration, inputOptions, prog
 	if (!dependencyContext.versionRange) dependencyContext.versionRange = packageJsonVersionRange;
 	const { versionRange } = dependencyContext;
 	if (versionRange) {
-		dependencyContext.isSemVerVersionRange = isSemVerValidRange(dependencyContext.versionRange);
+		dependencyContext.isSemVerVersionRange = isSemVerRange(dependencyContext.versionRange);
 		if (!dependencyContext.isSemVerVersionRange) {
 			log[resolveLogLevel(dependentContext, progressData)](
 				"%s references %s not by semver range %s", dependentContext.name, name, versionRange

diff --git a/lib/utils/is-sem-ver-range.js b/lib/utils/is-sem-ver-range.js
@@ -0,0 +1,8 @@
+"use strict";
+
+const semver = require("semver");
+
+module.exports = versionRange => {
+	if (versionRange === "latest") return true;
+	return semver.validRange(versionRange);
+};