Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/plop template #105

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Bugfix/plop template #105

merged 3 commits into from
Mar 24, 2023

Conversation

AlenaAlyona
Copy link
Contributor

@AlenaAlyona AlenaAlyona commented Mar 23, 2023 •
edited
Loading

Minor fixes:

  1. remove unused import

Plop template fixes:

  1. should output correctly in hooks folder
  2. stories file: add return type to a function
  3. test file: import

@AlenaAlyona AlenaAlyona added the bug Something isn't working label Mar 23, 2023
@AlenaAlyona AlenaAlyona requested review from ThaNarie, leroykorterink and a team March 23, 2023 14:15
@AlenaAlyona AlenaAlyona self-assigned this Mar 23, 2023
@ThaNarie @AlenaAlyona
Fix and update plop files
3fcbf83 
- should output correctly in hooks folder
- was breaking because of missing `}`
- was missing `.js` extension when added in `src/index.ts`
@AlenaAlyona AlenaAlyona changed the title Bugfix/plop template stories file Bugfix/plop template Mar 24, 2023
@AlenaAlyona AlenaAlyona merged commit 0485017 into main Mar 24, 2023
@leroykorterink leroykorterink deleted the bugfix/plop-template-stories-file branch May 31, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leroykorterink leroykorterink leroykorterink approved these changes

@ThaNarie ThaNarie ThaNarie approved these changes

Assignees

@AlenaAlyona AlenaAlyona

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlenaAlyona @ThaNarie @leroykorterink