This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
Add flake8, correct errors #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroberts
approved these changes
Jan 28, 2018
|
Thanks Colin, looks good to me too! Before merging, could you please add a note about linting in |
ColCarroll
force-pushed
the
add_flake8
branch
from
1486f77 to
50659d9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206
Adds an automated code linter. I would rather use pylint which does a bit more aggressive checking, but there is an issue related to our symlinking the
snowballproject (see pylint-dev/pylint#1470. The fix works, but is not worth maintaining a fork ofastroid). I am also ignoring the code generated fromsnowball.