initial choice type support #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelbuesing
force-pushed
the
impl-choice
branch
from
6863a5d to
89c2fc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial support of the choice element. There are quite a number of edge cases I fear. I think best would have been to turn this into an enum, the problem I had is that the id field is optional so I had no idea where to get a name from for the enum. Right now it's not enforced that only a single element can be set. If anyone comes up with a solution for the name I think that would be great, from every perspective I think the enum would be more convenient than multiple optional fields.
What's missing:
properminOccurs,maxOccurshandlingextensionas a parentrestrictionas a parentsequenceas a parent