-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.2.0 #65
Release 0.2.0 #65
Conversation
Getting this error for Python 2.7 and Numpy 1.16.5 on Windows:
|
Also getting this with Python 3.6.10 and NumPy1.18.4:
|
Hah, i had this issue before: numpy/numpy#15003 |
I solved it in my PR. I should probably have made a separate one for this. You need to add |
Thanks. That seems like something new conda requires. |
conda is always a bit tricky with its activation, especially on Windows. I don't think it will break for something related anymore this way though. |
@apommel I've bumped to version 0.2.0 in this PR. Can you review and let me know if there are any other things that need to be done before a release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems fine among the changes.
I can't seem to add it directly with te review tool, but maybe the environment variable IPOPTWINDIR
in setup.py
could be renamed IPOPT_DIR
as it is a more standard name for an environment variable.
I think I specifically didn't use IPOPT_DIR for some reason, but can't quite recall. This would be backwards incompatible, so I'll leave it for this release. |
No description provided.