Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom colors #39

Open
Unknow0059 opened this issue Jan 25, 2024 · 1 comment · May be fixed by #41
Open

Custom colors #39

Unknow0059 opened this issue Jan 25, 2024 · 1 comment · May be fixed by #41

Comments

@Unknow0059
Copy link

As per #38, customly defined colors cause no change.
@Unknow0059
Copy link
Author

This happens when you use one of the >10 syntax options Rainbow CSV adds.

If you use "Enable: set character or text as a separator", it works.

parasyte added a commit to parasyte/sublime_rainbow_csv that referenced this issue Aug 28, 2024
@parasyte
Fix custom color scheme
d6ffb76 
- The color scheme path could not be found due to a syntax error
  (case sensitivity).
- When pregenerated grammars are used, the wrong settings path was
  chosen.
  - And auto detection/reloading package settings wasn't working when
    Rainbow CSV syntax was auto-detected by file extension, because then
    it was no longer "plain text".
- Use json5 to parse Syntax-specific settings and set the color scheme.
  - Fixes a bug where modifying the Syntax-specific settings would
    conflict with how the color scheme was enabled and disabled:
  - A pre-existing settings file would prevent the color scheme from
    being used.
  - Disabling the custom color scheme would remove all settings,
    including user preferences like disabling `word_wrap`.
  - Unfortunately, comments are not preserved, so this still leads to
    some data loss. See: dpranke/pyjson5#28

Closes mechatroner#39
@parasyte parasyte linked a pull request Aug 28, 2024 that will close this issue
Open
parasyte added a commit to parasyte/sublime_rainbow_csv that referenced this issue Aug 28, 2024
@parasyte
Fix custom color scheme
b11ea9e 
- The color scheme path could not be found due to a syntax error
  (case sensitivity).
- When pregenerated grammars are used, the wrong settings path was
  chosen.
  - And auto detection/reloading package settings wasn't working when
    Rainbow CSV syntax was auto-detected by file extension, because then
    it was no longer "plain text".
- Use json5 to parse Syntax-specific settings and set the color scheme.
  - Fixes a bug where modifying the Syntax-specific settings would
    conflict with how the color scheme was enabled and disabled:
  - A pre-existing settings file would prevent the color scheme from
    being used.
  - Disabling the custom color scheme would remove all settings,
    including user preferences like disabling `word_wrap`.
  - Unfortunately, comments are not preserved, so this still leads to
    some data loss. See: dpranke/pyjson5#28

Closes mechatroner#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix syntax file extensions and custom color scheme parasyte/sublime_rainbow_csv
1 participant
@Unknow0059