-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csv_align and csv_shrink to take ranges ? #51
Comments
Thank you for your interest in this project! And I would greatly appreciate it if you could add a unit test for this feature otherwise there is a chance that it could break at some point later - I don't typically do a lot of manual testing after refactorings because it is very time-consuming. |
First attempt will be to just convert align and shrink to accept a range of lines. I've roughed-in the first parts for align this afternoon. Tomorrow, I take on shrink. Can you point me to any existing unit tests for the align and shrink functions? maybe I can modify those for this purpose. Is there any adjacent functionality I should be considering ? Thanks |
@carywreams Oh no. There are no existing unit tests for align and shrink. I was sure I had them, this is probably because I have such tests for VSCode version of the extension. Ignore my test request please, I will need to start by adding regular align shrink tests. Sorry for the confusion! |
Regarding the adjacent functionality - nothing particular comes to mind, the remaining features should be orthogonal to the alignment because there are no assumptions about how input CSV files are aligned originally i.e. the extension should be robust to any leading/trailing whitespaces |
…csv_align to use either address or visual range
…tance as well as requirements for ranges when using align and shrink functions in those filetypes
…ce to README.md
…ce to autoload/.vim and doc/.txt
Cant the plugin be modified to operate on ranges? I'd like to give it a go unless there's an inherent reason that won't work.
My specific use case is for my tables in markdown files.
e.g.
:.,+10RainbowAlignRange
or
:7,39RainbowShrinkRange
The text was updated successfully, but these errors were encountered: