Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename id-3.json to id.json #257

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

cr0i
Copy link
Contributor

@cr0i cr0i commented Nov 11, 2024

Hello @meatpiHQ ,

I tried to create my first pullrequest.

1.:
I think all VW id series will be the same, so i renamed the file from id-3 to id.
In Carscanner the Profile is named: "EV MEB: ID.3, ID.4, ID.5, ID.7, ID.BUZZ, Enyaq, Elroq, Q4 E-tron, Cupra Born, Cupra Tavascan, etc."
Because of this there are some other brands for this (VW, Skoda, Cupra, Audi), could this info be left anywhere else?

2.:
All names are lowercase now, because it never worked for someone it should be no problem?

3.:
changed, sorted and tested the content in the JSON-File.

@cr0i cr0i requested a review from meatpiHQ as a code owner November 11, 2024 02:44
@meatpiHQ
Copy link
Owner

In Carscanner the Profile is named: "EV MEB: ID.3, ID.4, ID.5, ID.7, ID.BUZZ, Enyaq, Elroq, Q4 E-tron, Cupra Born, Cupra Tavascan, etc."
Because of this there are some other brands for this (VW, Skoda, Cupra, Audi), could this info be left anywhere else?

@jay-oswald any suggestion how to handle long names?

@jay-oswald
Copy link
Collaborator

@meatpiHQ I think my inheritance system I want to do could fix this as well.

That way we could have a single VW ID profile that has all the stuff in it, and we can create say Skoda: Enyaq which just inherits from VW ID.

That way someone looking at profiles can see it extends VW ID, but most users just selecting their car its still easy to see their car name in the list.

This would be a 100% JS change, so the end result would be just lots of profiles same as we have now, just easier to manage vehicle by vehicle

I just need to do the work to make inheritance happen, will solve a few problems all at once

@jay-oswald
Copy link
Collaborator

So I think for this PR how its done is good, and when I add inheitance then we can add all the other various brands/models that all just inheit from here

@meatpiHQ meatpiHQ merged commit b03b943 into meatpiHQ:main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants