Automatically count required staging checks #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now Anubis requests the list of required staging checks from GitHub 'stating branch' settings instead of maintaining its own config::staging_checks parameter. That parameter was problematic because it was usually out of sync with the actutal list of required checks. With new approach, the list of required staging checks should still be kept up-to-date. However, it became easier because it must include CI checks only (GitHub check runs are maintained automatically).
Anubis now expects that the staging branch protection includes the complete list of required checks. That list is extracted from GitHub (the same way as for PR itself) and the size of that list is the actual number of expected staging checks.
| @@ -234,7 +229,7 @@ class StatusChecks | |||
|
|
|||
| // no more required status changes or additions are expected | |||
| final() { | |||
| return (this.requiredStatuses.length >= this.expectedStatusCount) && | |||
| return (this.requiredStatuses.length >= this._contextsRequiredByGitHubConfig.length) && | |||
There was a problem hiding this comment.
this.requiredStatuses.length should be <= this._contextsRequiredByGitHubConfig.length because this.requiredStatuses gets only those statuses that are among this._contextsRequiredByGitHubConfig. So we can probably assert the '<=' condition here and use '==' instead for the returning condition.
| expected to auto-test the staging branch on every change. A check | ||
| failure is a PR-specific step failure -- in GitHub terminology, all | ||
| staging checks are currently deemed "required". If discovered, any | ||
| extra check is considered a configuration problem (not related to any |
There was a problem hiding this comment.
Now all 'extra' checks will be treated as optional (i.e., the checks that are not 'required').
| @@ -1016,10 +1018,13 @@ class PullRequest { | |||
| statusChecks.addOptionalStatus(new StatusCheck(st)); | |||
| } | |||
There was a problem hiding this comment.
_getPrStatuses() and _getStagingStatuses() look almost the same now, except for this dealing with 'copied' statuses (although the diff does not show it clearly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Anubis requests the list of required staging checks from GitHub
'stating branch' settings instead of maintaining its own
config::staging_checks parameter. That parameter was problematic because
it was usually out of sync with the actual list of required checks.