-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
LGTM. Also, I'm cool with combining the PRs and just squashing down to two commits (one for the eslint addition, and one for the formatting changes). |
I'm also fine with two commits in one PR. I'd like to take this for a quick test run, and review. I should be able to complete that in an hour or so. |
LGTM. Thanks @ilanbiala |
@ilanbiala Upon looking at this again, I realized the Gulp task is failing.. It throws an error at this line
|
@mleanos I'm thinking it stems from this line because we don't pass in a formatter and when it tries to write it can't execute the function because it's undefined https://github.com/adametry/gulp-eslint/blob/master/util.js#L180. Can you paste in the stack trace if there is one? |
I'm going to do them as 2 separate PRs because I already have it set up like that locally. @mleanos try adding |
@ilanbiala adding ".eslint" to that line fixed the Gulp issues.. This LGTM now! Thank you :) |
716134d
to
0323696
Compare
I missed the party but good thing to see this already fixed and joined in with the eslint file! |
This has all the formatting changes and ESLint support (temporarily so we can confirm it passes in Travis).