This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Global Mocha timeout #972
Merged
Global Mocha timeout #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mleanos just merge the Grunt and Gulp PRs together. |
|
@ilanbiala Ok, will do. I just thought we were keeping Grunt & Gulp separate since we're not officially supporting Gulp. |
Added the timeout option to the Mocha grunt task; set to 10000. Removed the individual test suite timeouts, for all server tests. Also, added global timeout for Mocha gulp task.
mleanos
force-pushed
the
mocha-global-timeout-grunt
branch
from
882c056 to
037878b
Compare
|
@ilanbiala Combined the Gulp change into this PR. |
|
LGTM (grunt & gulp test-ed). Thanks. |
|
@ilanbiala I think we can add it as part of 0.4.2, you have any objections? |
|
LGTM. 👍 |
|
LGTM |
|
Thank you @lirantal @vaucouleur Thanks for the suggestion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the timeout option to the Mocha grunt task; set to 10000.
Removed the individual test suite timeouts, for all server tests.
As discussed in #964