-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
@codydaig here is my first stab at moving the documentation for Cloud Foundry. I tried to run
any idea how to fix that? |
@ryanjbaxter Ah. Yes. That's a funky issue. If you remove the node_modules folder from the root directory it will work. I will submit a pull request to fix that and have jekyll exclude that directory. Because node_modules is in the gitignore, when you switch branches, it leaves it behind. |
@codydaig thanks that worked! I made some more minor tweaks and added links to the CF documentation from the main page. Let me know what you think. |
@ryanjbaxter The final structure change just got merged in, so the links that you added and going to cause conflicts that need to get resolved before this can be merged in. |
Guys we can't merge this because of conflicts, please take a look. |
@ryanjbaxter You have docs04x.html in the root directory and that file does not exist anymore. Delete that file and then it will be ready to merge. |
@ilanbiala nope. |
@ilanbiala I'm not familiar with CF either. I'd suggest we push this off to 0.4.x, then I can test within the next week before we merge this. Plus, this requires #681 to be merged in too be valid. |
Sure, it's nothing critical for 0.4.0 |
@lirantal @ilanbiala @codydaig this should now be all set. as should be #732 Not sure why it needs to be pushed off now, the instructions explain how to test this out and I am willing to help anyone who needs it. |
My initial pull request was pushed off for months I dont want this to happen again. |
@ryanjbaxter understood, don't worry, we're just getting through 0.4.0 first. |
@ryanjbaxter it doesn't even need to be pushed off. Since it isn't breaking anything, we can just release 0.4.1 with this change once we get it tested. |
@ilanbiala ok as long as that happens fairly quickly |
@ryanjbaxter Having experience in dev ops, how long do you think it will take me to setup? |
@codydaig it will take you a minute to sign up for Bluemix or Pivotal Web Services, 3 minutes to install the CF CLI, and then you can deploy the app. If you want to setup the social services you will spend a couple minutes issuing some basic CF CLI commands, nothing hard though. |
@ryanjbaxter Here's my command line history showing you the steps that I took. The node_modules folder got uploaded with the cf push and the app is not working.
Also, here is a gist of the logs when I request the home page: |
@codydaig thanks for trying it out! I screwed up the formatting in the .cfignore file, it should be fixed now (as well as the documentation issues) can you try again? |
@ryanjbaxter I'm probably overlooking something, but if you are excluding node_modules and public/lib, why do we need to run npm install and grunt build locally before we push? (other than local dev reasons) |
@codydaig because when deployed to CF we use the JS in public/dist |
Yup. Knew I was overlooking something small. |
@ryanjbaxter - Per the conversation on Gitter, Add something to the documentation to change the app name in the manifest file and the documentation for this will be good to go. (Grammar is not my strong suite, so if anyone wants to check grammar, they should do so). |
@codydaig I added a troubleshooting section specifying how to deal with the multiple urls. There is also one more enhancement I would like to make to the documentation to make deployments easier but it can be (and had to be made) after these changes are merged. I can add a "Deploy To Bluemix" button to the documentation that allows the user to deploy MEANJS to Bluemix with a single click. This way they dont have to install the CF CLI, run npm, and run grunt to get it deployed. However I need the changes in #732 to be merged in before testing this. |
@ryanjbaxter Congrats! Your commit has been merged in! Is this ready to be reviewed and merged in or do you want to make your change with the one click button? |
</ul> | ||
</li> | ||
</ul> | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanjbaxter New Line Please
@ryanjbaxter Go ahead and squash the commits and add the new line and I'll give my approval. |
LGTM |
Great, thanks @ryanjbaxter ! |
Initial Cloud Foundry documentation
No description provided.