Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Initial Cloud Foundry documentation #716

Merged
merged 1 commit into from
Aug 8, 2015
Merged

Initial Cloud Foundry documentation #716

merged 1 commit into from
Aug 8, 2015

Conversation

ryanjbaxter
Copy link
Contributor

No description provided.

@ryanjbaxter
Copy link
Contributor Author

@codydaig here is my first stab at moving the documentation for Cloud Foundry. I tried to run jekyll serve to see what it looks like but got an error

$ jekyll serve
Configuration file: /Users/ryanjbaxter/git-repos/ryanjbaxter/mean/_config.yml
            Source: /Users/ryanjbaxter/git-repos/ryanjbaxter/mean
       Destination: /Users/ryanjbaxter/git-repos/ryanjbaxter/mean/_site
      Generating...
jekyll 2.5.3 | Error:  undefined method `default_proc=' for "this --- is correct":String

any idea how to fix that?

@codydaig
Copy link
Member

@ryanjbaxter Ah. Yes. That's a funky issue. If you remove the node_modules folder from the root directory it will work. I will submit a pull request to fix that and have jekyll exclude that directory. Because node_modules is in the gitignore, when you switch branches, it leaves it behind.

@ryanjbaxter
Copy link
Contributor Author

@codydaig thanks that worked! I made some more minor tweaks and added links to the CF documentation from the main page. Let me know what you think.

@codydaig
Copy link
Member

@ryanjbaxter The final structure change just got merged in, so the links that you added and going to cause conflicts that need to get resolved before this can be merged in.

@lirantal
Copy link
Member

Guys we can't merge this because of conflicts, please take a look.
Also @ryanjbaxter please rebase and squash your commits so we can merge.

@ryanjbaxter
Copy link
Contributor Author

@codydaig and @lirantal i just fixed the merge conflicts

@codydaig
Copy link
Member

@ryanjbaxter You have docs04x.html in the root directory and that file does not exist anymore. Delete that file and then it will be ready to merge.

@ilanbiala
Copy link
Member

@codydaig is everything good other than the extra html file? @lirantal are you familiar with CF at all? I'm not really familiar.

@lirantal
Copy link
Member

@ilanbiala nope.

@codydaig
Copy link
Member

@ilanbiala I'm not familiar with CF either. I'd suggest we push this off to 0.4.x, then I can test within the next week before we merge this. Plus, this requires #681 to be merged in too be valid.

@ilanbiala
Copy link
Member

@lirantal @codydaig has a good idea. Let's push it off.

@lirantal
Copy link
Member

Sure, it's nothing critical for 0.4.0

@ryanjbaxter
Copy link
Contributor Author

@lirantal @ilanbiala @codydaig this should now be all set. as should be #732

Not sure why it needs to be pushed off now, the instructions explain how to test this out and I am willing to help anyone who needs it.

@ryanjbaxter
Copy link
Contributor Author

My initial pull request was pushed off for months I dont want this to happen again.

@lirantal
Copy link
Member

@ryanjbaxter understood, don't worry, we're just getting through 0.4.0 first.

@ilanbiala
Copy link
Member

@ryanjbaxter it doesn't even need to be pushed off. Since it isn't breaking anything, we can just release 0.4.1 with this change once we get it tested.

@ryanjbaxter
Copy link
Contributor Author

@ilanbiala ok as long as that happens fairly quickly

@codydaig
Copy link
Member

@ryanjbaxter Having experience in dev ops, how long do you think it will take me to setup?

@ryanjbaxter
Copy link
Contributor Author

@codydaig it will take you a minute to sign up for Bluemix or Pivotal Web Services, 3 minutes to install the CF CLI, and then you can deploy the app. If you want to setup the social services you will spend a couple minutes issuing some basic CF CLI commands, nothing hard though.

@codydaig
Copy link
Member

@ryanjbaxter Here's my command line history showing you the steps that I took. The node_modules folder got uploaded with the cf push and the app is not working.
http://mean-exosporous-ensemble.cfapps.io/

522  cf login -a https://api.run.pivotal.io
523  cd ~/Desktop/mean-0.4.0-cf
524  cf create-service mongolab sandbox mean-mongo
525  npm install
526  cf push

Also, here is a gist of the logs when I request the home page:
https://gist.github.com/codydaig/0bb2eb3a0aab808f3ba2

@ryanjbaxter
Copy link
Contributor Author

@codydaig thanks for trying it out! I screwed up the formatting in the .cfignore file, it should be fixed now (as well as the documentation issues) can you try again?

@codydaig
Copy link
Member

@ryanjbaxter I'm probably overlooking something, but if you are excluding node_modules and public/lib, why do we need to run npm install and grunt build locally before we push? (other than local dev reasons)

@ryanjbaxter
Copy link
Contributor Author

@codydaig because when deployed to CF we use the JS in public/dist

@codydaig
Copy link
Member

Yup. Knew I was overlooking something small.
It worked! http://mean-unfacaded-desponder.cfapps.io/
Side question, anytime I make a change and push, it adds another url to the urls list. So currently, this app has 3 urls that all render the same and access the same database. Is this normal or what am I missing? (I'm on gitter if that's easier too)

@codydaig
Copy link
Member

@ryanjbaxter - Per the conversation on Gitter, Add something to the documentation to change the app name in the manifest file and the documentation for this will be good to go. (Grammar is not my strong suite, so if anyone wants to check grammar, they should do so).

@ryanjbaxter
Copy link
Contributor Author

@codydaig I added a troubleshooting section specifying how to deal with the multiple urls.

There is also one more enhancement I would like to make to the documentation to make deployments easier but it can be (and had to be made) after these changes are merged. I can add a "Deploy To Bluemix" button to the documentation that allows the user to deploy MEANJS to Bluemix with a single click. This way they dont have to install the CF CLI, run npm, and run grunt to get it deployed. However I need the changes in #732 to be merged in before testing this.

@codydaig
Copy link
Member

codydaig commented Aug 7, 2015

@ryanjbaxter Congrats! Your commit has been merged in! Is this ready to be reviewed and merged in or do you want to make your change with the one click button?

</ul>
</li>
</ul>
</section>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanjbaxter New Line Please

@codydaig
Copy link
Member

codydaig commented Aug 7, 2015

@ryanjbaxter Go ahead and squash the commits and add the new line and I'll give my approval.

@codydaig
Copy link
Member

codydaig commented Aug 8, 2015

LGTM

@lirantal
Copy link
Member

lirantal commented Aug 8, 2015

Great, thanks @ryanjbaxter !

lirantal added a commit that referenced this pull request Aug 8, 2015
Initial Cloud Foundry documentation
@lirantal lirantal merged commit c57ee98 into meanjs:gh-pages Aug 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants