PayPal Authentication #610
Conversation
|
@trainerbill looks like some conflicts exist there, can you look into it? |
|
@lirantal What conflicts? I merged the PayPalAuth4 branch with 0.4.0 successfully. |
|
@trainerbill I don't know what conflicts but take a look at the merge notice: It says clearly "we can't automatically merge this pull request" |
|
@lirantal Ok, I fixed the merge conflicts but it required getting up to date with meanjs/0.4.0 so there are a ton of changes that I didn't make... Not sure if this is the proper way to handle this or not. |
| @@ -43,6 +43,7 @@ | |||
| "passport": "~0.2.2", | |||
| "passport-facebook": "^2.0.0", | |||
| "passport-github": "~0.1.5", | |||
| "passport-paypal-openidconnect": "^0.1.1", | |||
| clientID: process.env.PAYPAL_ID || 'CLIENT_ID', | ||
| clientSecret: process.env.PAYPAL_SECRET || 'CLIENT_SECRET', | ||
| callbackURL: '/api/auth/paypal/callback', | ||
| sandbox: false |
There was a problem hiding this comment.
What does this property mean?
There was a problem hiding this comment.
@ilanbiala I see that in the strategy, you can set the sandbox option for testing with the sandbox environment instead of production so you don't actually charge the paypal account.
https://github.com/shekhei/passport-paypal-openidconnect/blob/master/lib/passport-paypal-openidconnect/strategy.js#L54
if true, it will use the sandbox urls:
https://github.com/shekhei/passport-paypal-openidconnect/blob/master/lib/passport-paypal-openidconnect/strategy.js#L12
If false, it will use the live endpoints:
https://github.com/shekhei/passport-paypal-openidconnect/blob/master/lib/passport-paypal-openidconnect/strategy.js#L7
|
@ilanbiala Fixed the indentation. Stupid atom. as @jloveland mentioned it is an option to switch between sandbox/testing mode and production mode for Login With PayPal |
|
thanks @trainerbill! |
New PR for PayPal Authentication for 0.4.0 branch