Join 2 articles public form views into one for sake of DRY #339
Conversation
|
In my opinion it is extremely helpful to have best practices in demo code. Is there a reason this hasn't been merged yet? |
|
@ramusus Would you mind updating this PR against the latest master branch? I'd really like to see this change myself. Unless there's any objections of moving to a dry structure? @lirantal @ilanbiala @mleanos @trainerbill @rhutchison |
| $scope.article.title = ''; | ||
| $scope.article.content = ''; | ||
| } | ||
| var error = function(errorResponse) { |
|
@ramusus this looks fine to me, albeit some changes that need to be made such as removing |
|
@ramusus would you be able to tidy up this PR so it can be merged? |
|
Sorry, unfortunatly I'm very busy now |
|
@ilanbiala #874 is a refactor of the Article module. However, since that PR is set for 0.5.0 then this can probably move forward without consideration for both #807 and #874 |
|
@ilanbiala Can this be moved to 0.5.0? |
|
mleanos do you need #874 to work on this? |
|
@ilanbiala I'm not sure. I need to take another look at this implementation. I'd rather wait until the dust settles with #874 since it's a huge refactor, and this implementation might not be relevant once we implement John Papa's styleguide; I'm not exactly sure though. Also, #807 will introduce a change in how we're allowing users to edit/create Articles, it may make sense to hold off on this; or just address these concerns in #807 |
|
@rhutchison I agree. I would like to reintroduce this with #807. Also, would prefer to add the angular styleguide with it, since the article refactor PR has stalled for so long. We need to get moving on the styleguide, so we can have it out with the 0.5.0 release. |
Update the articles module to implement the style guidelines. Much of this work is from @trainerbill Closes meanjs#874 Closes meanjs#339
Update the articles module to implement the style guidelines. Much of this work is from @trainerbill Closes meanjs#874 Closes meanjs#339
Solves #336