This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
feat(build): Ignore compiled sass/less files from git #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleanos
reviewed
Oct 23, 2016
| @@ -31,7 +31,7 @@ module.exports = { | |||
| tests: ['public/lib/angular-mocks/angular-mocks.js'] | |||
| }, | |||
| css: [ | |||
| 'modules/*/client/css/*.css' | |||
| 'modules/*/client/{css,less,scss}/*.css' | |||
There was a problem hiding this comment.
How does this affect the less & sass settings below?
mleanos
reviewed
Oct 23, 2016
| @@ -169,9 +169,6 @@ gulp.task('sass', function () { | |||
| return gulp.src(defaultAssets.client.sass) | |||
| .pipe(plugins.sass()) | |||
| .pipe(plugins.autoprefixer()) | |||
| .pipe(plugins.rename(function (file) { | |||
|
@mleanos Now, both My proposal is to compile |
|
@shanavas786 Thank you. That perfectly answered my questions. Also, I agree with the goals of these changes. It's definitely gonna be easier to manage these compiled assets. @meanjs/contributors comments? |
mleanos
approved these changes
Oct 25, 2016
This was referenced Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling
sass/lessfiles to<module>/client/cssdirectory makes it difficult to differentiate between compiled and raw css files.By compiling them to appropriate directories, compiled files can be easily ignored.