This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
feat(users): get profile picture from provider in oauth signup #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleanos
suggested changes
Oct 15, 2016
| @@ -160,7 +160,7 @@ exports.saveOAuthUserProfile = function (req, providerUserProfile, done) { | |||
| lastName: providerUserProfile.lastName, | |||
| username: availableUsername, | |||
| displayName: providerUserProfile.displayName, | |||
| profileImageURL: providerUserProfile.profileImageURL, | |||
| profileImageURL: providerUserProfile.providerData.image.url, | |||
There was a problem hiding this comment.
This field is only present on Google+. I tested with Facebook, Twitter, Google+, and GitHub. This breaks the authentication for each one that I tested, other than Google+. Also, the Google+ authenticates but the image reference is incorrect. The url has a "http://localhost" prepended to the url coming from the provider. This actually seems to be an issue in the current master without this change.
@itelo Can you look into whether or not there's a way to reconcile these urls, by inspecting the providerUserProfile fields that are returned for these provider?
There was a problem hiding this comment.
@mleanos I found a strange bug, I'll cancel the PR until better understand what 's happening
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.