feat(core): Add prod asset versioning #1536
Conversation
|
Coverage remained the same at 73.224% when pulling d7f91e70120c2d748c767aefc853f2bd045f9013 on sujeethk:assetversioning into e3eafa6 on meanjs:master. |
|
maxAge is currently set to 1 day for all the static routes assuming vendor assets will not change in a day. Do we need asset versioning for vendor assets as well? If so, they would have to be moved to dist folder and versioned. If this is accomplished then maxAge can be set to a year or more. |
|
Coverage remained the same at 73.224% when pulling 652af06ec3556d065791afab25b1a6a0ab90331f on sujeethk:assetversioning into a7aebbd on meanjs:master. |
1 similar comment
|
Coverage remained the same at 73.224% when pulling 652af06ec3556d065791afab25b1a6a0ab90331f on sujeethk:assetversioning into a7aebbd on meanjs:master. |
| @@ -24,6 +24,8 @@ var _ = require('lodash'), | |||
| protractor = require('gulp-protractor').protractor, | |||
| webdriver_update = require('gulp-protractor').webdriver_update, | |||
| webdriver_standalone = require('gulp-protractor').webdriver_standalone, | |||
| rev = require('gulp-rev'), | |||
There was a problem hiding this comment.
why not use plugins.rev() below?
1 similar comment
|
Looks good, thanks. |
feat(core): Add prod asset versioning
Asset versioning for prod - idea from #1509
Fixes #1509