Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Cleaning up unused parameters in logger setup #1521

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Cleaning up unused parameters in logger setup #1521

merged 1 commit into from
Sep 19, 2016

Conversation

lirantal
Copy link
Member

Fixes #1482

@lirantal lirantal self-assigned this Sep 19, 2016
@lirantal lirantal added this to the 0.5.0 milestone Sep 19, 2016
@lirantal
Copy link
Member Author

@mleanos check if this is simple enough for a clean up

@mleanos
Copy link
Member

mleanos commented Sep 19, 2016

LGTM.

@coveralls
Copy link

coveralls commented Sep 19, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 73.284% when pulling aae2707 on lirantal:fix/logger-cleanup-unused-parameters into 015a430 on meanjs:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 73.284% when pulling aae2707 on lirantal:fix/logger-cleanup-unused-parameters into 015a430 on meanjs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 73.284% when pulling aae2707 on lirantal:fix/logger-cleanup-unused-parameters into 015a430 on meanjs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 73.284% when pulling aae2707 on lirantal:fix/logger-cleanup-unused-parameters into 015a430 on meanjs:master.

mleanos
mleanos approved these changes Sep 19, 2016
View reviewed changes
Copy link
Member

@mleanos mleanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you can merge this whenever you want. No need for further review.

@lirantal lirantal merged commit 89e8d13 into meanjs:master Sep 19, 2016
Wuntenn pushed a commit to Wuntenn/mean that referenced this pull request Sep 20, 2016
@lirantal
fix(logger): cleaning up unused parameters in logger setup (meanjs#1521)
2f1d9db
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mleanos mleanos mleanos approved these changes

Assignees

@lirantal lirantal

Labels
enhance:feature platform:node
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lirantal @mleanos @coveralls