This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
doc(package): Change meanjs version to 0.5.0-beta #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the version to 0.5.0-beta so people know that this is beta code and things are rapidly changing.
|
Seems fine to me I guess. |
|
LGTM - should we also update changelog up until this point? |
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "name": "meanjs", | |||
| "description": "Full-Stack JavaScript with MongoDB, Express, AngularJS, and Node.js.", | |||
| "version": "0.4.2", | |||
| "meanjs-version": "0.4.2", | |||
| "version": "0.5.0-beta", | |||
There was a problem hiding this comment.
@codydaig @ilanbiala how about we go with 0.5.0-rc1 instead?
the beta wording seems to generic for me
There was a problem hiding this comment.
It doesn't really matter too much to me, the whole point is to just tag it as different so people know.
There was a problem hiding this comment.
I wanted to leave it generic on purpose. To me, RC1 indicates a specific release, where beta just says it's currently under development and changing.
There was a problem hiding this comment.
So go ahead and merge then, I don't see it as that much of an issue.
codydaig
added a commit
that referenced
this pull request
Feb 24, 2016
doc(package): Change meanjs version to 0.5.0-beta
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the version to 0.5.0-beta so people know that this is beta code and things are rapidly changing.