This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix(tests) fixing assertion test for logger which failed #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Out of curiosity.. Under what conditions did this test fail? Was it when the logger options were not set in the environment config? |
|
LGTM |
|
@mleanos it failed locally, maybe I have a newer shouldjs library, not sure. It wasn't related to the actual logging options in the env config (although that could be a different issue). It anyway insisted that the options.should object is undefined for some reason. |
lirantal
added a commit
that referenced
this pull request
Dec 28, 2015
fix(tests) fixing assertion test for logger which failed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logger test failed on undefined variable