Fix static files BEFORE sessions #1090
Conversation
To avoid a mongo ping per static file.
|
@pursual Thank you for submitting this fix. The build failed due to a timeout. You can close & re-open this PR, to initialize the build process again. Hopefully, it was just an intermittent timeout. |
|
LGTM. Any other considerations? @codydaig @ilanbiala @lirantal |
|
@pursual Before this is merged, you will need to change the commit message to conform to the Contributing guidelines. This is for the commit history, and to easily track changes in release changelog's. https://github.com/meanjs/mean/blob/master/CONTRIBUTING.md#commit-message-guidelines |
fix(core): Serve static files without session init Small change to config/lib.express.js. Move static routes config above session init. Fixes #1089
|
@pursual The actual commit message, not the body should contain the header. See these commits.. |
|
I'm away for the weekend, feel free to close and recreate. On Fri, Dec 4, 2015, 7:52 PM Michael Leanos [email protected]
|
|
Code LGTM, I don't there there are any issues with doing that. |
Small change to config/lib.express.js. Move static routes config above session init. Fixes #1089
|
Squash the commits and then LGTM |
|
Sorry, I give up, you guys have the info needed. On Sat, Dec 5, 2015, 12:15 PM Cody B. Daig [email protected] wrote:
|
* 'master' of https://github.com/pursual/mean: fix(core): Serve static files without session init fix(core): Serve static files without session init Update express.js Fix static files BEFORE sessions
|
Closed and resubmitted. |
To avoid a mongo ping per static file. #1089