response code 500 on accessing non-existing document?

[FREEZX]

Hi,

I'm currently developing an application using mean, and something caught my attention:
https://github.com/meanjs/mean/blob/master/app/controllers/articles.server.controller.js#L93

This returns 500 internal server error if the document does not exist.
In my opinion this should send back 404 Not Found, without disclosing a stack trace.

[lirantal]

You're right @FREEZX so I committed a PR for that.
Notice though, that there's no specific route calling for getting an article by id, but rather it's a route parameter resolution.

[ilanbiala]

@lirantal isn't the specific route this one? That just calls articleById internally and sends the result.

[lirantal]

@ilanbiala that's the route but it uses the :articleId parameter which is resolved using express's app.param() method.

[ilanbiala]

@lirantal yep, that's what I said. So what's the consensus, should we at least send a 400 if the id is not a valid ObjectId? I think we should start with that and work forward.

[lirantal]

merged the relevant PR so I'm closing this.