-
Notifications
You must be signed in to change notification settings - Fork 2k
docker in production mode fails #1453
Comments
@soupman99 are you using the newly added Dockerfile-production you mean? @FedeG can you take a look? |
@soupman99 yep it's clear, there's no gulp file there. |
Even though Can you open a shell in the container to test if gulp is indeed available as a global command? |
@soupman99. If you want use gulp in a npm command, you will be install gulp local (and gulp tasks) or install dev-dependencies. @lirantal. Can we switch gulp and gulp tasks to dependencies? (if you want, I do today and i add the .dockerignore. Also i update the dockerfile with we saw at #1468) |
@soupman99 can you please test my PR (linked to this open issue) with the modified dockerfile-production and let me know how that goes? |
@FedeG I don't want to move gulp and gulp-tasks to dependencies because some installs may not use gulp at all for their production environments. |
@lirantal wait, isn't |
right, which is why I'm saying that it isn't needed to add it in the dependencies section |
… production and fix this bug meanjs#1453
@lirantal, I tests your PR: build successfully and image run successfully. |
In my fork, i'm testing a new dockerfile for #1468. |
Great, I'll go ahead and merge it then. |
Getting this error. Running on a clean machine. Any ideas on what could be causing it?
The text was updated successfully, but these errors were encountered: