Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Should gulp test:server:watch default to "onlyChanged"? #1297

Closed
simison opened this issue Apr 6, 2016 · 3 comments
Closed

Should gulp test:server:watch default to "onlyChanged"? #1297

simison opened this issue Apr 6, 2016 · 3 comments

Comments

@simison
Copy link
Member

simison commented Apr 6, 2016

This:

gulp test:server:watch --onlyChanged

...should really be default when hitting that test-watch task (gulp test:server:watch).

Are there situations when you'd want to run all the tests when changing something at a single test file? Wouldn't it be enough to run all the tests only at the end of development manually?

Thoughts?

@mleanos
Copy link
Member

mleanos commented Apr 7, 2016

I think defaulting to only running a changed test is a good idea. I don't really see a need to run all tests again, after changing a single test file.

@ilanbiala
Copy link
Member

SGTM.

@mleanos
Copy link
Member

mleanos commented Apr 8, 2016

@simison I'll submit a PR for this change, since I introduced this task.

mleanos added a commit to mleanos/mean that referenced this issue Apr 10, 2016
Sets the behavior of the test:server:watch Gulp task to only run a single
test suite if the modified server file is a test suite. Previously this was
acheived through the use of the `onlyChanged` parameter. The parameter has
been removed since this is almost certainly the only use case.

Also, refactors this Gulp task to be a stand-alone watch task rather than
including it in the 'watch' task.

Removed the need for using yargs library, and removed the yargs package
from the framework.

Closes meanjs#1297
mleanos added a commit that referenced this issue Apr 10, 2016
Sets the behavior of the test:server:watch Gulp task to only run a single
test suite if the modified server file is a test suite. Previously this was
acheived through the use of the `onlyChanged` parameter. The parameter has
been removed since this is almost certainly the only use case.

Also, refactors this Gulp task to be a stand-alone watch task rather than
including it in the 'watch' task.

Removed the need for using yargs library, and removed the yargs package
from the framework.

Closes #1297
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants